Skip to content

feat: Add tracing to load, server actions, and handle/resolve #13900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: elliott/init-tracing
Choose a base branch
from
Draft

feat: Add tracing to load, server actions, and handle/resolve #13900

wants to merge 2 commits into from

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github commented Jun 17, 2025 •
edited
Loading

Adds spans to load (on the server), server actions, and handle/resolve.

We're punting on clientside tracing for now, as we do not feel the o11y community has sufficiently converged on approaches (see https://github.com/open-telemetry/community/blob/main/projects/browser-phase-1.md). When OTEL provides a stable and truly browser-native tracing platform, we'll be all over it.

Want to play around with it?

Clone the repo: https://github.com/elliott-with-the-longest-name-on-github/test-tracing

Set up something like Jaeger (you can copy and run the Docker command at the top of this file to get it up and running with UI and ingestion ports): https://www.jaegertracing.io/docs/2.7/getting-started/

Then build and run your app:

pnpm build && node --import ./instrumentation.server.mjs build/index.js

Visit localhost:3000/one/two/three/four, click some buttons to see different scenarios. This will generate traces you can view in Jaeger.

TODO:

  • Configuration to enable globally enabling or disabling telemetry
  • Tests
  • Ask for comments from community -- esp. around what data we're capturing in our attributes and how it's structured, whether we need any additional API surface for annotating spans
  • Test on serverless platforms

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3516dd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Closed
6 tasks
@elliott-with-the-longest-name-on-github Graphite App
Copy link
Contributor Author

elliott-with-the-longest-name-on-github commented Jun 17, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Draft
6 tasks
@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github marked this pull request as ready for review June 17, 2025 21:18
elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github commented Jun 18, 2025
View reviewed changes
packages/kit/src/runtime/shared.js
* @param {any} data
* @param {string} [location_description]
*/
export function validate_load_response(data, location_description) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to shared to reduce duplication

packages/kit/types/index.d.ts
* - `'server'` - Enable tracing only on the server side
* - `'client'` - Enable tracing only on the client side
* @default false
* @since 2.22.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github force-pushed the elliott/trace-fns branch 2 times, most recently from 4995112 to 7a3909c Compare June 20, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elliott-with-the-longest-name-on-github